Re: [Gambas-devel-svn] SF.net SVN: gambas:[7637] gambas/trunk/gb.xml/src/textnode.cpp

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Gambas-devel-svn] SF.net SVN: gambas:[7637] gambas/trunk/gb.xml/src/textnode.cpp

Tobias Boege-2
On Tue, 15 Mar 2016, [hidden email] wrote:

> Revision: 7637
>           http://sourceforge.net/p/gambas/code/7637
> Author:   tobiasboe
> Date:     2016-03-15 17:16:58 +0000 (Tue, 15 Mar 2016)
> Log Message:
> -----------
> [GB.XML]
> * BUG: Fix copy & paste error (?) which creates CDATA nodes as comment nodes.
>
> Modified Paths:
> --------------
>     gambas/trunk/gb.xml/src/textnode.cpp
>

Adrien, if you are here, could you check on this fix? I found this bug by
a CDATA node which obviously contained data in my XML file but returned an
empty TextContent and was later serialised to a <!--...--> comment. Alas,
I'm not so familiar with the XML theory to justify the change.

Regards,
Tobi

--
"There's an old saying: Don't change anything... ever!" -- Mr. Monk

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
_______________________________________________
Gambas-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gambas-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Gambas-devel-svn] SF.net SVN: gambas:[7637] gambas/trunk/gb.xml/src/textnode.cpp

Adrien Prokopowicz-2
Le Tue, 15 Mar 2016 18:45:24 +0100, Tobias Boege <[hidden email]> a  
écrit:

> On Tue, 15 Mar 2016, [hidden email] wrote:
>> Revision: 7637
>>           http://sourceforge.net/p/gambas/code/7637
>> Author:   tobiasboe
>> Date:     2016-03-15 17:16:58 +0000 (Tue, 15 Mar 2016)
>> Log Message:
>> -----------
>> [GB.XML]
>> * BUG: Fix copy & paste error (?) which creates CDATA nodes as comment  
>> nodes.
>>
>> Modified Paths:
>> --------------
>>     gambas/trunk/gb.xml/src/textnode.cpp
>>
>
> Adrien, if you are here, could you check on this fix? I found this bug by
> a CDATA node which obviously contained data in my XML file but returned  
> an
> empty TextContent and was later serialised to a <!--...--> comment. Alas,
> I'm not so familiar with the XML theory to justify the change.
>
> Regards,
> Tobi
>

The fix looks good to me, it was indeed a copy & paste error.

Right now I'm looking to get the gb.xml components covered by unit tests,
these errors are starting to be really annoying ...

Anyway, thanks for the fix. :-)

Regards,

--
Adrien Prokopowicz

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
_______________________________________________
Gambas-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gambas-devel